On Fri, 28 Feb 2025 21:09:30 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/BorderPaneTest.java >> line 349: >> >>> 347: assertEquals(240 /* l + r + c*/, borderpane.prefHeight(-1), >>> 1e-10); >>> 348: assertEquals(110, borderpane.minWidth(-1), 1e-100); /* min >>> center + 2x pref width (l, r) */ >>> 349: assertEquals(20 /*t*/ + 200 /*c*/ + 20 /*b*/, >>> borderpane.minHeight(-1), 1e-10); >> >> minor: Do you think it'll be easier to define the constants explicitly, line >> >> double L = 40; >> double C = 200; >> >> and use those? > > I just copied the style that was being used, but can make any changes desired > of course (at the expense of increasing the diff and amount of code to > review). I know it's a general policy not to do unrelated changes or reformatting, but I think in this case a) it's a test and b) you already touched it so might as well. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1723#discussion_r1976016376
