On Sun, 9 Feb 2025 19:10:49 GMT, Thiago Milczarek Sayao <tsa...@openjdk.org> wrote:
> The issue was with the view's position, specifically the content's X and Y > coordinates relative to the window, including its decorations. When in > fullscreen mode, the window remains decorated, but the decorations are > hidden. As a result, the content's position needs to be recalculated to > account for the window's adjusted layout. > > It's not specific to i3. > > I used `gdk_window_get_root_origin` because GTK will try harder to find the > value, even if `_NET_FRAME_EXTENTS` is not supported on some Window Manager. I've tested successfully on Ubuntu, with or without i3 wm, and Fedora+Sway. It looks good, but I had to add some debug info myself for better understanding of the changes... so that's why I left one remark. modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 983: > 981: geometry.y = root_y; > 982: geometry.view_x = origin_x - root_x; > 983: geometry.view_y = origin_y - root_y; Looks good, but maybe you could add a small comment about what `x/y` and `view_x/view_y` mean? ------------- PR Review: https://git.openjdk.org/jfx/pull/1702#pullrequestreview-2608366331 PR Review Comment: https://git.openjdk.org/jfx/pull/1702#discussion_r1950635001
