On Thu, 16 Jan 2025 22:34:35 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> I second @jperedadnr concern about combining separate issues into one PR. >> Small focused PRs will get tested, reviewed, and integrated almost always >> faster than the big complicated ones. > > Completely agree, but in this case, the fix for > [JDK-8276326](https://bugs.openjdk.org/browse/JDK-8276326) is also the same > for [JDK-8346824](https://bugs.openjdk.org/browse/JDK-8346824) - that is the > `VirtualFlow` changes. > It is not really possible to separate those issues. > What I could try is to cherrypick the changes from the `VirtualFlow`, leaving > out the virtualization optimizations. Although this was not the original > point here. > > The reason those are together is that they are very closely related. Fixing > the virtualization without the `VirtualFlow` will still break applications > and tests because you can somewhat randomly get empty cells. > > Fixing the `VirtualFlow` first might work, but if you scroll enough you will > get empty cells because of broken virtualization. > So this PR got bigger in order to have a working virtualization and also > scrolling behavior with no empty cells. > If it really helps, I can split them up, as mentioned above. probably not worth it at this point, I think. We just need to be extra careful during the review to consider all the scenarios involved. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1644#discussion_r1919330155
