On Tue, 10 Dec 2024 18:07:44 GMT, Marius Hanl <mh...@openjdk.org> wrote:

> The JUnit Platform got some updates over the last years, so it is a good idea 
> to update it to the newest version.
> 
> That is from `5.8.1` to `5.11.3`.
> Affected dependencies:
> - `junit.jupiter`
> - `junit.platform`
> - `opentest4j`
> 
> Release notes: https://junit.org/junit5/docs/5.11.3/release-notes/
> 
> Note:
> I did a handful of CI runs and got a test failure once in 
> `ServiceLifecycleTest`. Not sure yet if related to the update or not.

I confirmed my theory about why that test is now failing, and filed a new bug, 
[JDK-8346222](https://bugs.openjdk.org/browse/JDK-8346222), to track this. PR 
#1664 is out for review.

I have a CI build out with the patches from both PRs. Once that completes, I'll 
approve this. It would probably be best to wait until Monday, unless I'm able 
to integrate PR #1664 is integrated sooner than that (as a simple testbug I 
will integrate that one without waiting 24 hours if it is approved sooner).

One more thing: I updated the title of the JBS bug to match our usual pattern 
for third-party updates. Please update the title of your PR to match.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1662#issuecomment-2542189326

Reply via email to