On Tue, 26 Nov 2024 18:50:18 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> Centralizes version numbers in a single place. This is not the best way of >> doing it in Gradle, but it's an improvement that will simplify other >> changes. I used the `build.properties` file because other versions are >> already written there. >> >> There are other version numbers in the build file, but they are not attached >> directly to a dependency. Mostly libav ones. I decided not to touch them. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Added EOF line I agree that this is a good idea and something I do as well in Maven and Gradle projects. Putting them in the `build.properties` is fine. Changes look good to me. ------------- Marked as reviewed by mhanl (Committer). PR Review: https://git.openjdk.org/jfx/pull/1649#pullrequestreview-2462598537
