On Tue, 26 Nov 2024 16:03:38 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
> Centralizes version numbers in a single place. This is not the best way of > doing it in Gradle, but it's an improvement that will simplify other changes. > I used the `build.properties` file because other versions are already written > there. > > There are other version numbers in the build file, but they are not attached > directly to a dependency. Mostly libav ones. I decided not to touch them. The changes look good. I'll do a quick CI test build before approving. build.properties line 123: > 121: icu.version=74.2 > 122: antlr4.version=4.7.2 > 123: lucene.version=7.7.3 Minor: Add a (single) blank line at the end of this file? ------------- PR Review: https://git.openjdk.org/jfx/pull/1649#pullrequestreview-2462227460 PR Review Comment: https://git.openjdk.org/jfx/pull/1649#discussion_r1858943810
