On Thu, 19 Sep 2024 15:11:56 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/concurrent/ScheduledServiceTest.java
>> line 95:
>>
>>> 93: }
>>> 94:
>>> 95: @Override public void setup(TestServiceFactory factory) {
>>
>> could have inserted a newline after the annotation...
>
> this particular test is not parameterized, so you could use `@BeforeEach` to
> setup the factory. Same for the `ServiceLifecycleTest`.
>
> it won't work for `ServiceExceptionTest` because it is parameterized.
>
> but this code is ok too.
Changed it to use `@BeforeEach` in non-parametrized classes
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1566#discussion_r1768585178
