By the way, regarding Metal, I don't know what state it's in. The work is done only by Oracle, so they will have to answer that (probably Kevin). The work is ongoing in the jfx sandbox: https://github.com/openjdk/jfx-sandbox/tree/master.
I didn't see questions other than that. Did I miss them? On Thu, Sep 12, 2024 at 3:59 PM Nir Lisker <nlis...@gmail.com> wrote: > Do you mind taking a look, and maybe helping answer some of my questions? >> I'm just not getting any replies, so I'm somewhat confused. >> > > I'll try to take a closer look during the weekend. There are a lot of > issues in my queue that I can't find the time to get to. Also be patient > with the replies, it takes time to get to an issue because there are many > ideas/drafts and not a lot of people. > > The #1281 PR was closed due to inactivity. The next step there is to do a > review of potential settings to add and check if it makes sense to add both > sampler states and render states to the same class. See > https://github.com/openjdk/jfx/pull/1281#discussion_r1412368579. > > You can see all the threads in the mailing list archive: > http://mail.openjdk.java.net/pipermail/openjfx-dev/. > > On Tue, Sep 10, 2024 at 4:22 AM Knee Snap <kneeste...@gmail.com> wrote: > >> @Nir Lisker <nlis...@gmail.com> Do you mind taking a look, and maybe >> helping answer some of my questions? I'm just not getting any replies, so >> I'm somewhat confused. >> >> ALSO, unrelated, I'm hoping to pick up the PR you dropped before: >> https://github.com/openjdk/jfx/pull/1281 >> What would be the process for me taking over your PR? I don't have access >> to the original RFR email thread or feature proposal as I only recently >> joined the mailing list. >> >> Thanks! >> >> On Fri, Sep 6, 2024 at 4:32 PM Knee Snap <kneeste...@gmail.com> wrote: >> >>> Hi all, while waiting on Kevin to review the feature proposal (if I >>> understand the process correctly), I have created a draft PR if anyone >>> wants to have a look. It's not clear to me if we should be discussing >>> implementation yet, the guide seems to contradict itself at points. But I >>> think since we seem to have no further design discussion points we're okay >>> to talk about implementation? >>> >>> Draft PR: https://github.com/openjdk/jfx/pull/1557 >>> >>> >>> On Thu, Sep 5, 2024 at 9:08 PM Knee Snap <kneeste...@gmail.com> wrote: >>> >>>> Thanks everyone who has commented and given feedback. >>>> >>>> With no further discussion points brought up, I'd like to move this >>>> proposal along for review, and hopefully CSR creation. >>>> >>>> Is there anything I need to do besides say I'm ready to move forward? >>>> @Kevin >>>> Rushforth <kevin.rushfo...@oracle.com> >>>> >>>> >>>> >>>> On Wed, Sep 4, 2024, 12:24 PM Knee Snap <kneeste...@gmail.com> wrote: >>>> >>>>> I don't know what gamma refers to in the context of vertex colors, >>>>> sorry. >>>>> >>>>> It's not using the gamma color space if that's the question (but >>>>> neither is the rest of JavaFX 3D). >>>>> >>>>> If gamma is meant as opacity, then setting the alpha color value will >>>>> control opacity. >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> On Wed, Sep 4, 2024, 7:44 AM Andy Goryachev <andy.goryac...@oracle.com> >>>>> wrote: >>>>> >>>>>> I am not a 3D expert; one question: how is the gamma value set for >>>>>> color interpolation? >>>>>> >>>>>> >>>>>> >>>>>> Thanks! >>>>>> >>>>>> -andy >>>>>> >>>>>> >>>>>> >>>>>> *From: *openjfx-dev <openjfx-dev-r...@openjdk.org> on behalf of Knee >>>>>> Snap <kneeste...@gmail.com> >>>>>> *Date: *Tuesday, September 3, 2024 at 23:53 >>>>>> *To: *openjfx-dev@openjdk.org <openjfx-dev@openjdk.org> >>>>>> *Subject: *[Feature Proposal]: TriangleMesh - Vertex Color Support >>>>>> >>>>>> Hello all, >>>>>> >>>>>> >>>>>> >>>>>> This is a continuation of a previous email thread: "[Feature >>>>>> Proposal] Vertex Colors on TriangleMesh". >>>>>> >>>>>> I'm creating a new email thread because after discussion I've put >>>>>> together a feature proposal, and it serves largely as a summary of the >>>>>> previous email thread. (Better organized as a feature proposal) >>>>>> >>>>>> >>>>>> >>>>>> *Feature Proposal:* >>>>>> https://github.com/Kneesnap/misc-public/blob/main/documents/javafx/feature-proposals/vertex-colors/proposal.md >>>>>> >>>>>> I had previously discussed a draft PR, but considering how simple the >>>>>> proposed public API additions are to discuss, I don't think it's actually >>>>>> that helpful. >>>>>> >>>>>> >>>>>> >>>>>> *What's next?* >>>>>> >>>>>> I'm currently happy with the design and seeing as it's been discussed >>>>>> already, I could probably ask Kevin for a review. But, I'd like to give >>>>>> another opportunity for design discussion before doing so, just in-case >>>>>> there are any further considerations brought up. >>>>>> >>>>>> So, I open up the floor again. Does anyone have any thoughts on this >>>>>> proposal? Concerns? Questions? Suggestions? Constructive criticism? I >>>>>> eagerly await the feedback. >>>>>> >>>>>> >>>>>> >>>>>> After API discussion concludes, I plan to pass it off to Kevin for >>>>>> review/approval, and if it is approved, the subsequent CSR creation. >>>>>> >>>>>> >>>>>> >>>>>> Thanks! >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>
