On Sat, 10 Aug 2024 11:33:43 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Yes, that's a good idea, I was mainly worried about introducing a new public >> API that we can't remove later when we haven't figured out yet what the best >> direction would be. With this API removed, I think we can get this merged. > > One more thing. You introduced `transition` short hand version. Is it maybe > a good idea to not do this yet until we have a better idea how to deal with > them? Shorthand properties are just a convenience; the feature will work > without them. If it was already released, then can ignore this as we're too > late. The `transition` shorthand is already on track to be released, and we’re deep into RDP2. However, `TransitionDefinitionConverter` is not public API, it’s implementation can move around freely. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1712646742
