On Wed, 7 Aug 2024 15:12:22 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>>> would it be easier just to pass a boolean to the constructor? we are 
>>> changing the public API anyway...
>> 
>> Usually boolean parameters are not a good API choice, but I have no strong 
>> opinion on this one. What do you prefer?
>
> I just think it's much simpler than an annotation...
> 
> Or it could be a public instance method `boolean isSupportReconstruction()` 
> for the child classes to override, saving N (1? 8?) bytes per instance.

But the annotation costs no bytes per instance, if that even matters, as I 
thought these were singletons so it looks like we're quite into 
micro-optimization territory here.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1707250058

Reply via email to