On Mon, 8 Jul 2024 21:49:42 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add many more unit tests for Tooltip
>
> tests/system/src/test/java/test/robot/javafx/scene/TooltipTest.java line 64:
>
>> 62:
>> 63: private static void assertTooltipShowDelay(long tooltipShowTime,
>> long expectedTime) {
>> 64: assertTooltipShowDelay(tooltipShowTime, expectedTime, 50);
>
> If I change this to 100, then all tests pass most of the time. So maybe 150
> or 200 would be a better maximum delta?
>
> If you do make this change, then you will need to find all of the three-arg
> calls with a maxDifference less than that and change them to the two-arg
> version.
even with max=200 we might see occasional failures due to load or other
circumstances.
I wonder a better approach would be to check whether the measurement of the
delay falls sufficiently outside of the default 1000 ms (which in itself might
be more than that)?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1394#discussion_r1669397953
