On Thu, 4 Jul 2024 09:32:39 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not inside `Tooltip`, but
>> inside the `TooltipBehaviour`. So the very first `Tooltip` gets processed
>> correctly, but after no `Tooltip` will be processed by CSS before showing,
>> resulting in the set `-fx-show-delay` to not be applied immediately.
>>
>> Added a bunch of headful and headless tests for the behaviour since there
>> were none before.
>
> Marius Hanl has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add many more unit tests for Tooltip
The new system test isn't stable on Windows. I ran it several times, and most
of the time I see one or two failures. Here are the results from a couple of
the test runs:
Test run 1:
TooltipTest > testShowDelayCssShowTooltipTwice() FAILED
org.opentest4j.AssertionFailedError: 193 <= 150 ==> expected: <true> but
was: <false>
TooltipTest > testSmallShowDelayCssTooltip() FAILED
org.opentest4j.AssertionFailedError: 160 <= 150 ==> expected: <true> but
was: <false>
Test run 2:
TooltipTest > testShowDelayCssShowTooltipTwice() FAILED
org.opentest4j.AssertionFailedError: 165 <= 150 ==> expected: <true> but
was: <false>
TooltipTest > testChangeShowDelayTooltip() FAILED
org.opentest4j.AssertionFailedError: 151 <= 150 ==> expected: <true> but
was: <false>
This is likely due to either inaccuracies in the timer itself or in measuring
the elapsed time.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1394#issuecomment-2215341859
