On Wed, 3 Jul 2024 14:27:19 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> eduardsdv has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains five additional commits >> since the last revision: >> >> - Merge remote-tracking branch 'refs/remotes/origin/master' into >> bugfix/JDK-8322619-render-dirty-flag >> - JDK-8322619: Fix waiting for the stage >> - JDK-8322619: Improve output message in test >> - JDK-8322619: Avoid using of Thread.sleep(..) >> - JDK-8322619: Combine clearDirtyTree() and clearDirty() methods. > > I have tested the patch with several samples. Fix looks good. > Though the test fails on my Mac machine with below error. > Please verify.. > > > NGNodeDirtyFlagTest > testNGNodesNotDirty FAILED > org.junit.ComparisonFailure: A node was not rendered properly. Wrong > color found expected:<[LIGHTGREEN]> but was:<[0x81ee7eff]> > at org.junit.Assert.assertEquals(Assert.java:117) > at > test.com.sun.prism.impl.NGNodeDirtyFlagTest.checkColor(NGNodeDirtyFlagTest.java:135) > at > test.com.sun.prism.impl.NGNodeDirtyFlagTest.lambda$checkLineColor$5(NGNodeDirtyFlagTest.java:126) > > 1 test completed, 1 failed > >> Task :systemTests:test FAILED @arapte: The failed test on the Mac is probably caused by the lack of synchronization between the JavaFX and QuantumRenderer threads. I added the ``waitForRenderer()`` method to wait for the stage to render before checking the colors.. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1451#issuecomment-2206776887
