> This is an alternative solution to the PR: > https://github.com/openjdk/jfx/pull/1310. > > This solution is based on the invariant that if a node is marked as dirty, > all ancestors must also be marked as dirty and that if an ancestor is marked > as clean, all descendants must also be marked as clean. > Therefore I removed the ``clearDirtyTree()`` method and put its content to > the ``clearDirty()`` method. > > Furthermore, since dirty flag is only used when rendering by ``ViewPainter``, > it should also be deleted by ``ViewPainter`` only. > This guarantees: > 1. that all dirty flags are removed after rendering, and > 2. that no dirty flags are removed when a node is rendered, e.g. by creating > a snapshot or printing. > Therefore I removed all calls of the methods ``clearDirty()`` and > ``clearDirtyTree()`` from all other classes except the ``ViewerPainter``. > > The new version of the ``clearDirty()`` method together with calling it from > the ``ViewerPainter`` needs to visit far fewer nodes compared to the version > prior this PR. > > The supplied test checks that the nodes are updated even if they are > partially covered, which led to the error in the version before the PR. The > test can be started with ``gradlew -PFULL_TEST=true :systemTests:test --tests > NGNodeDirtyFlagTest``
eduardsdv has updated the pull request incrementally with four additional commits since the last revision: - JDK-8322619: Move to the test.robot.com.sun.prism package and use TOLERANCE when comparing colors - JDK-8322619: Add copyright header - JDK-8322619: Add waiting for rendering before taking a snapshot - JDK-8322619: Remove unused field; Add stage.setAlwaysOnTop(..); stage.initStyle(..) ------------- Changes: - all: https://git.openjdk.org/jfx/pull/1451/files - new: https://git.openjdk.org/jfx/pull/1451/files/e3bd58f3..ac971e14 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=1451&range=03 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1451&range=02-03 Stats: 353 lines in 2 files changed: 163 ins; 190 del; 0 mod Patch: https://git.openjdk.org/jfx/pull/1451.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/1451/head:pull/1451 PR: https://git.openjdk.org/jfx/pull/1451
