On Fri, 24 May 2024 12:12:27 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> > > I wonder if we may want to add some tests for the `FixedCapacitySet`? > > > > > > Yeah, now that it is more likely that this will make it into FX, I will add > > a small set of unit tests for this class. > > Since this PR is ready to integrate, I think it would be fine to file a new > test bug for the additional tests if you like. If you prefer to add the new > tests now, that's fine, too (we can re-review it). I'm fine integrating this as-is and adding a test soon after. I will leave this over the weekend to give others time to review. Also some clarification on the contributing rules: "all Reviewers who have requested the chance to review have done so" -- does the indication at the top right of the PR count towards this or should it be a comment? :) In the first case, @nlisker and @arapte, please indicate if you wish to review this still. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1316#issuecomment-2129527739
