On Tue, 7 May 2024 19:54:52 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8282999: Add for support EXT-X-MEDIA tag in HTTP Live Streaming [v2] > > modules/javafx.media/src/main/java/com/sun/media/jfxmedia/locator/HLSConnectionHolder.java > line 58: > >> 56: import static >> com.sun.media.jfxmedia.locator.HLSConnectionHolder.HLS_VALUE_MIMETYPE_MP3; >> 57: import static >> com.sun.media.jfxmedia.locator.HLSConnectionHolder.HLS_VALUE_MIMETYPE_UNKNOWN; >> 58: import static >> com.sun.media.jfxmedia.locator.HLSConnectionHolder.stripParameters; > > If you make the other classes in this file nested static classes, then you > won't need these static imports. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1435#discussion_r1594747872
