On Wed, 8 May 2024 06:00:30 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8282999: Add for support EXT-X-MEDIA tag in HTTP Live Streaming [v2] > > modules/javafx.media/src/main/native/jfxmedia/Locator/Locator.cpp line 123: > >> 121: >> "(Lcom/sun/media/jfxmedia/locator/ConnectionHolder;)Lcom/sun/media/jfxmedia/locator/ConnectionHolder;"); >> 122: env->DeleteLocalRef(klass); >> 123: if (javaEnv.reportException() || >> (GetAudioStreamConnectionHolder == NULL)) > > Observed a build warning (MacOS): > > warning: comparison of function 'GetAudioStreamConnectionHolder' equal to a > null pointer is always false [-Wtautological-pointer-compare] Good catch. That looks like a typo to me, and should probably be `mid_GetAudioStreamConnectionHolder == null` ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1435#discussion_r1593947105
