On Sat, 4 May 2024 14:17:16 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> whitespace
>
> modules/javafx.controls/src/main/java/javafx/scene/control/Labeled.java line
> 855:
>
>> 853: }
>> 854:
>> 855: private ReadOnlyBooleanWrapper textTruncated() {
>
> ~Suggestion: rename this method to something like `textTruncatedImpl()` for
> clarity (as it is, the method, which is a writable property, shares the same
> name as the read-only property field, which could be confusing).~
Never mind. I missed that the types of the field and method are identical, so I
withdraw my suggestion.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1389#discussion_r1590957454
