On Tue, 26 Mar 2024 20:53:17 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> improve (stub) font tests, fallback and documentation > > modules/javafx.graphics/src/test/java/test/com/sun/javafx/pgstub/StubTextLayout.java > line 40: > >> 38: * <br> >> 39: * Can calculate the bounds of text by simply using the size of the font. >> 40: * If the text is bold, the font will be 1 pixel bigger. > > maybe change to "somewhat wider" instead, since the height is the same? sure! Fun fact: I also was not happy with the javadoc but couldn't come up with a better wording. Fixed now. :) ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1422#discussion_r1542106527
