On Tue, 26 Mar 2024 20:25:07 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> I am not sure why this is needed here, so my concern stems from the fact >> that `ceil()` might introduce a large bias (0.000001 -> 1.0), and `rnd()` >> _seems_ to be a better choice. >> >> But then again, ceil() or rnd() might be a wrong thing to do if we are >> dealing with scaled coordinates and we don't expect the whole integers, but >> instead are dealing with small differences between expected and obtained >> values (in which case a better comparison is required). > > I can also use `round` here. Seems to be a bit safer, I agree. thank you. one more question - is it possible to set fractional scale with the StubToolkit, and how would that work in the StubFontLoader? Does it mean we'll be rounding the scaled values? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1422#discussion_r1540073971
