On Mon, 5 Feb 2024 09:31:37 GMT, Robert Lichtenberger <rlich...@openjdk.org> wrote:
> A side comment: the default implementation of resizeColumnToFitContent() is > to iterate over all the rows, and I think this is not right. The UI locks up > if the table has, let's say, 10,000,000 rows. I think in this case it should > instead pick a reasonable limited range (maybe a max 1000 rows or so) of rows > based on what's currently visible, so as not to lock up the UI. This might be > a separate improvement. I agree as well. This is on my todo list for quite a while. The default auto size is done with 30 rows. If you double click the edge of the header, it will take ALL rows, which can be very slow. So +1 here. Also another idea I had is to take 15 top rows and 15 bttom rows into account. In case the table is sorted. We can disuss this more in a seperate issue. I will review this PR soon as well. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1358#issuecomment-1926583385
