On Fri, 2 Feb 2024 06:55:36 GMT, Robert Lichtenberger <rlich...@openjdk.org> wrote:
> The PR simply moves column and view-updates outside the loop. Since the > column or view never changes within the for-loop it is not necessary to call > these again and again. I see it working right in macOS 14.2.1, by double-clicking on the column divider in the table header. Question to @effad : could you provide the measurements for this fix (before/after) please? A side comment: the default implementation of resizeColumnToFitContent() is to iterate over all the rows, and I think this is not right. The UI locks up if the table has, let's say, 10,000,000 rows. I think in this case it should instead pick a reasonable limited range (maybe a max 1000 rows or so) of rows based on what's currently visible, so as not to lock up the UI. This might be a separate improvement. ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1358#pullrequestreview-1859623785
