On Thu, 20 Jul 2023 15:36:28 GMT, Hima Bindu Meda <hm...@openjdk.org> wrote:
> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1).
> Verified the updated version build, sanity tests and stability. No issues
> have been observed.
Oh, I see that now. What led me to ask this question was that there is an
alternative implementation in `#if PLATFORM(JAVA)`, which implies that we
removed the call to `stripLeadingAndTrailingHTMLSpaces` and that it is still
present in the upstream.
Given that this code block now matches the upstream, the `if..else..endif`
block should simply be replaced with:
return document().completeURL(linkAttribute);
removing the `#if PLATFORM(JAVA)` and the entire `#else` block (including the
old call to `stripLeadingAndTrailingHTMLSpaces`). Otherwise it will be
confusing and possibly lead to merge conflicts later.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1180#issuecomment-1646001246
