On Wed, 3 May 2023 16:02:34 GMT, John Neffenger <jgn...@openjdk.org> wrote:
> Please review these changes to the Gradle build files and the dependency
> verification file. The initial version of this pull request extends the
> permitted build platforms for Linux to the Java architectures `arm`,
> `ppc64le`, and `s390x` and adds an entry to the dependency verification file
> for the `i386` architecture. The Debian names for these architectures are
> `armhf`, `i386`, `ppc64el`, and `s390x`.
Changing the errors to warnings seems good, as does adding the additional
artifact. I left a question about the `IS_64` change.
buildSrc/linux.gradle line 48:
> 46: "-Wextra", "-Wall", "-Wformat-security", "-Wno-unused",
> "-Wno-parentheses", "-Werror=trampolines"] // warning flags
> 47:
> 48: if (OS_ARCH == "i386") {
Why was this change needed, and is it sufficient? It seems that there is a
larger problem (likely out of scope for this fix) as to how `IS_64` is set that
might need follow-up.
-------------
PR Review: https://git.openjdk.org/jfx/pull/1124#pullrequestreview-1437626675
PR Review Comment: https://git.openjdk.org/jfx/pull/1124#discussion_r1201130504
