On Thu, 18 May 2023 23:20:29 GMT, Andy Goryachev <[email protected]> wrote:
> My concern is that replacing == with .equals() in BitSet.equals() may lead to
> issues in internal CSS code. It is highly unlikely that application would
> extend BitSet, or put StyleClassSet in the same hash table due to both being
> in com.sun; but the internal code might (and I don't want to comb the CSS
> code looking for possible occurrences).
>
> If we replace line 532 with `if(getClass == obj.getClass()) {` however, we
> would not have to.
Alright, I see your point. The current version will always return `false` when
comparing `StyleClassSet` with a `PseudoClassState`. So does the (full)
solution in #1076 -- but this half copied solution doesn't, which is a slight
regression (probably harmless, but even so).
I'll fix it.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1070#issuecomment-1553782479
