On Thu, 18 May 2023 23:20:29 GMT, Andy Goryachev <[email protected]> wrote:
> It is highly unlikely that application would extend BitSet, or put
> StyleClassSet in the same hash table due to both being in com.sun;
Not merely unlikely, it is not possible, so this need not be considered.
> but the internal code might (and I don't want to comb the CSS code looking
> for possible occurrences).
>
> If we replace line 532 with `if(getClass == obj.getClass()) {` however, we
> would not have to.
That's a good suggestion. Given that we want the minimal changes to BitSet for
this particular PR, this seems a reasonable, and safe choice. `BitSet` is an
internal-only abstract class, and the only two concrete subclasses are both
final with different type parameters.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1070#issuecomment-1553782429
