On Mon, 27 Mar 2023 23:05:00 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
> Fix bug in CSS caching code that could reset values on unrelated nodes.
>
> The bug occurs due to a cache entry being constructed incorrectly when the
> initial node that triggered the cache entry creation has user set values. The
> calculated values for properties with a user set value were omitted in the
> cache entry, and other nodes that later share the same entry would
> incorrectly assume the omitted property was unstyled and were therefore reset
> to their default values.
Looks good to me.
modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java
line 614:
> 612:
> 613: @Test
> 614: public void
> initialNodeWithUserSetValueShouldNotResetValuesOnOtherNodesWithoutOverridenValue()
> throws IOException {
Typo: "Overridden"
-------------
Marked as reviewed by mstrauss (Committer).
PR Review: https://git.openjdk.org/jfx/pull/1072#pullrequestreview-1375287875
PR Review Comment: https://git.openjdk.org/jfx/pull/1072#discussion_r1160067506
