> The Robot implementation on Linux did not consult the current layout when 
> mapping from a KeyCode to a hardware code. Internally it retrieved results 
> for all the layouts but just picked the first one it saw leading to random 
> effects. Though not part of the original bug report, the code also ignored 
> the shift level when choosing which result to pick. On a French layout the 
> dollar sign is on two keys (AltGr 4 is the second one) and the code could 
> choose either one. Same is true for pound.
> 
> This PR consults the current layout and only on shift level 0 which is the 
> same level used in get_glass_key to figure out which KeyCode to assign when 
> generating a KeyEvent.

Martin Fox has updated the pull request incrementally with one additional 
commit since the last revision:

  The Robot code now correctly targets numlock keypad keys and keys that always 
appear on group 0.

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/718/files
  - new: https://git.openjdk.org/jfx/pull/718/files/51fcd047..ca9f5bf7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=718&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=718&range=01-02

  Stats: 77 lines in 2 files changed: 48 ins; 2 del; 27 mod
  Patch: https://git.openjdk.org/jfx/pull/718.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/718/head:pull/718

PR: https://git.openjdk.org/jfx/pull/718

Reply via email to