> This PR fixes 8273379. > > I reverted back to use GDK (from > [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events. > > It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383). > > There's also some cleaup. > > To do general testing (two tests were added): > `java @build/run.args -jar apps/toys/DragDrop/dist/DragDrop.jar` > > Information for reviewing: > * Previously an offscreen window where used to pass events. Now it gets the > window were Drag initially started > (`WindowContextBase::sm_mouse_drag_window`); > * There's a new `DragSourceContext` instead of global variables; > * DragView were simplified; > * It handles `GDK_GRAB_BROKEN` events (I still need to figure it out a test > case for this - It should happen when another window grabs the device during > the drag); > * There's a special case for `GDK_BUTTON_RELEASE` because `WindowContext` > will notify java about the button release and set `DnDGesture` to null before > the end of the DND. > * `gdk_drag_find_window_for_screen` -> pass the DragView window to be ignored > (as it would "steal" destination motion events); > * The Scenario were the drag source window closes during the drag is now > covered; > * It does not rely on `gdk_threads_add_idle` because it may be inconsistent. > > >  > 
Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 76 commits: - Merge branch 'master' into 8273379-dnd-keys - Merge branch 'openjdk:master' into master - Merge branch 'openjdk:master' into master - Merge branch 'openjdk:master' into master - Merge branch 'openjdk:master' into master - Merge branch 'openjdk:master' into master - Merge branch 'openjdk:master' into master - Merge branch 'openjdk:master' into master - Merge branch 'openjdk:master' into master - Don't call gdk_device_manager_get_client_pointer() on event processing - ... and 66 more: https://git.openjdk.org/jfx/compare/0c03a411...2302657e ------------- Changes: https://git.openjdk.org/jfx/pull/986/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=986&range=29 Stats: 962 lines in 9 files changed: 611 ins; 177 del; 174 mod Patch: https://git.openjdk.org/jfx/pull/986.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/986/head:pull/986 PR: https://git.openjdk.org/jfx/pull/986
