On Mon, 20 Feb 2023 14:15:07 GMT, Jose Pereda <jper...@openjdk.org> wrote:
> This PR removes an unnecessary check that was added as part of > [JDK-8267551](https://bugs.openjdk.org/browse/JDK-8267551). > > As commented in the [issue](https://bugs.openjdk.org/browse/JDK-8300872), > there were no failing/passing tests before/after these lines were added, and > there are no actual tests that get into the case. > > The mentioned check caused, as a side effect, the JDK-8300872 issue, as > running under a (deprecated) security manager fails with: > > java.security.AccessControlException: access denied ("java.io.FilePermission" > "jrt:/javafx.controls/com/sun/javafx/scene/control/skin/modena/pattern-transparent.png" > "read") > ... > at javafx.graphics/javafx.scene.image.Image.validateUrl(Image.java:1127) > ... > > when `File::exists` is evaluated over an image bundled in a jar. I've added a system test, that passes with the proposed fix and fails without it. Without the fix, the AccessControlException exception prevents the color chooser dialog from showing up, but its window still reports onShowing true and the color can be still changed programmatically. There is an exception logged, but to make the test actually fail, I had to check for the window dimensions. ------------- PR: https://git.openjdk.org/jfx/pull/1042
