> This is my (joachim.schr...@gmx.de) first contribution to openjfx. My > Contributor Agreement is signed but still in review. > So please be patient with an absolute beginner as contributor ... . > The work of this pull request was fully done in my spare time. > > I first filed the bug myself in 2017. I had begun working with JavaFX in 2014. > > The two changes address the two problems mentioned in JDK-8173321: > - Using a JavaFX TableView, a click on the right trough has no effect when > the cell height of the cell currently displayed is higher than viewport height > - The ScrollBar ist displayed with a minimal height. > > The changes were tested and ran well with Java 17 and the current master > branch of openjfx.
JoachimSchriek has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision: - Merge branch 'openjdk:master' into master - Changes made after code review by Kevin Rushforth on Feb. 18 - Merge branch 'openjdk:master' into master - Merge branch 'openjdk:master' into master - Restore original VirtualFlow.java - Changes made following findings from review - Deleted trailing whitespace - Committed Test Case for [openjdk/jfx] 8173321: Click on trough has no effect when cell height > viewport (PR #985): - Replaces Tabs with Spaces - JDK-8173321: Click on trough has no effect when cell height > viewport height ------------- Changes: - all: https://git.openjdk.org/jfx/pull/985/files - new: https://git.openjdk.org/jfx/pull/985/files/29bf0519..b72c0104 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=985&range=09 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=985&range=08-09 Stats: 62 lines in 3 files changed: 38 ins; 13 del; 11 mod Patch: https://git.openjdk.org/jfx/pull/985.diff Fetch: git fetch https://git.openjdk.org/jfx pull/985/head:pull/985 PR: https://git.openjdk.org/jfx/pull/985