On Sat, 18 Feb 2023 15:32:48 GMT, JoachimSchriek <d...@openjdk.org> wrote:
>> This is my (joachim.schr...@gmx.de) first contribution to openjfx. My >> Contributor Agreement is signed but still in review. >> So please be patient with an absolute beginner as contributor ... . >> The work of this pull request was fully done in my spare time. >> >> I first filed the bug myself in 2017. I had begun working with JavaFX in >> 2014. >> >> The two changes address the two problems mentioned in JDK-8173321: >> - Using a JavaFX TableView, a click on the right trough has no effect when >> the cell height of the cell currently displayed is higher than viewport >> height >> - The ScrollBar ist displayed with a minimal height. >> >> The changes were tested and ran well with Java 17 and the current master >> branch of openjfx. > > JoachimSchriek has updated the pull request incrementally with one additional > commit since the last revision: > > Changes made after code review by Kevin Rushforth on Feb. 18 The updated fix and tests look good. I left one minor comment, but approved it anyway. I'll reapprove if you choose to fix it. tests/system/src/test/java/test/robot/javafx/scene/tableview/TableViewClickOnTroughTest.java line 72: > 70: static final int SCENE_WIDTH = 800; > 71: static final int SCENE_HEIGHT = 250; > 72: final static CountDownLatch startupLatch = new CountDownLatch(1); Minor: the preferred order of modifiers is `static final`. ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.org/jfx/pull/985
