On Tue, 22 Nov 2022 23:58:14 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 28 additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/master' into 8294809.listener.helper >> - 8294809: review comments >> - 8294809: review comments >> - Merge remote-tracking branch 'origin/master' into 8294809.listener.helper >> - 8294809: review comments >> - Merge remote-tracking branch 'origin/master' into 8294809.listener.helper >> - 8294809: whitespace >> - 8294809: no public api >> - 8294809: map change listener >> - Merge remote-tracking branch 'origin/master' into 8294809.listener.helper >> - ... and 18 more: https://git.openjdk.org/jfx/compare/f8eaf5ce...00566eda > > modules/javafx.controls/src/test/java/test/javafx/scene/control/TestListenerHelper.java > line 278: > >> 276: >> 277: @Test >> 278: public void testInvalidationListener_Callback() { > > Minor: This test is redundant, and the name of the test method is misleading. > Unlike `addChangeListener`, which really does have two similar flavors -- one > taking a `ChangeListener` and one taking a `Consumer`, there isn't a flavor > of `addInvalidationListener` that takes a Consumer, so this test method is > testing the same method (same signature) as `testInvalidationListener_Plain`. you found a bug in tests, thank you. > modules/javafx.controls/src/test/java/test/javafx/scene/control/TestListenerHelper.java > line 295: > >> 293: >> 294: @Test >> 295: public void testInvalidationListener_Callback_FireImmediately() { > > Minor: redundant (tests the same method signature as > `testInvalidationListener_Plain_FireImmediately`. another bug in tests. +1 ------------- PR: https://git.openjdk.org/jfx/pull/908
