On Wed, 23 Nov 2022 13:03:00 GMT, Marius Hanl <mh...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 28 additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'origin/master' into 8294809.listener.helper >> - 8294809: review comments >> - 8294809: review comments >> - Merge remote-tracking branch 'origin/master' into 8294809.listener.helper >> - 8294809: review comments >> - Merge remote-tracking branch 'origin/master' into 8294809.listener.helper >> - 8294809: whitespace >> - 8294809: no public api >> - 8294809: map change listener >> - Merge remote-tracking branch 'origin/master' into 8294809.listener.helper >> - ... and 18 more: https://git.openjdk.org/jfx/compare/a90da937...00566eda > > modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/IDisconnectable.java > line 34: > >> 32: */ >> 33: @FunctionalInterface >> 34: public interface IDisconnectable { > > I'm still in favor of remove the `I` in front of this interface. This is .NET > convention and not used in Java (at least I never saw it, and thinking of > naming `Iterable` -> `IIterable` would be weird anyway. I made a [similar comment](https://github.com/openjdk/jfx/pull/908#pullrequestreview-1168974400) about not using the `I` prefix earlier. Before this can be considered for public API (which won't be soon), this interface will need to be renamed. It seems best to discuss what it should be renamed to as part of the larger discussion about the API surface, functionality, and naming, so I didn't ask that it be renamed now. ------------- PR: https://git.openjdk.org/jfx/pull/908
