On Fri, 18 Nov 2022 17:00:42 GMT, Lukasz Kostyra <[email protected]> wrote:
>> modules/javafx.base/src/test/java/test/javafx/util/converter/LocalDateTimeStringConverterTest.java
>> line 60:
>>
>>> 58: private static final DateTimeFormatter aFormatter =
>>> DateTimeFormatter.ofPattern("dd MM yyyy HH mm ss");
>>> 59: private static final DateTimeFormatter aParser =
>>> DateTimeFormatter.ofPattern("yyyy MM dd hh mm ss a");
>>> 60: private static Locale oldLocale;
>>
>> I wonder how many other tests we have that depend on specific Locale?
>> Perhaps we need to apply the same treatment to:
>> - LocalDateStringConverterTest
>> - LocalTimeStringConverterTest
>
> I could also change those, as they use `DateTimeFormatter` as well which uses
> `Locale` underneath as discussed above. @kevinrushforth what do you think?
Yes, it seems reasonable to include those tests as well, since those tests have
the same problem.
-------------
PR: https://git.openjdk.org/jfx/pull/954
