On Thu, 17 Nov 2022 16:59:09 GMT, Lukasz Kostyra <[email protected]> wrote:
> The change moves Locale setting in the test to `@BeforeClass` and
> `@AfterClass` calls. `@BeforeClass` method call stores current default VM
> locale and applies Locale.US, while `@AfterClass` method restores old VM
> locale after all tests are completed.
>
> I tested it both on Mac and Windows, in both cases Locale is changed,
> restored properly and tests pass.
Looks good.
modules/javafx.base/src/test/java/test/javafx/util/converter/LocalDateTimeStringConverterTest.java
line 96:
> 94: }
> 95:
> 96: @BeforeClass public static void setupBeforeAll() {
Minor: we usually put annotations on a separate line, although some files (like
this one) put the `@Test` annotation on the same line, splitting them is
preferred. I'll approve it as-is, and reapprove if you decide to change (I'll
leave it up to you).
-------------
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.org/jfx/pull/954
