On Wed, 21 Sep 2022 07:53:42 GMT, Hima Bindu Meda <hm...@openjdk.org> wrote:
>> Updated icu to v71.1. >> Verified build and sanity testing on windows,Mac and Linux. >> Removed icu directory from Source/WTF, as the functionality is already >> provided by Source/ThirdParty/icu > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > > Update icu_web.md It looks like there are 4 missing blank lines in the newly added attribution. Otherwise looks good. modules/javafx.web/src/main/legal/icu_web.md line 446: > 444: suitability of this software for any purpose. It is provided "as is" > 445: without express or implied warranty. > 446: ---------------------------------------------------------------------- Add blank line above and below this line. modules/javafx.web/src/main/legal/icu_web.md line 450: > 448: File: selfmt.h > 449: File: selfmtimpl.h > 450: File: umsg.h Add blank line here. modules/javafx.web/src/main/legal/icu_web.md line 453: > 451: Copyright (c) 1995-2016 International Business Machines Corporation and > others > 452: All rights reserved. > 453: Copyright (C) 2010 , Yahoo! Inc. Add blank line here. ------------- PR: https://git.openjdk.org/jfx/pull/893
