On Wed, 7 Sep 2022 18:13:43 GMT, Hima Bindu Meda <hm...@openjdk.org> wrote:
> Updated icu to v71.1. > Verified build and sanity testing on windows,Mac and Linux. > Removed icu directory from Source/WTF, as the functionality is already > provided by Source/ThirdParty/icu One quick comment. I noticed that several files have changed from Unix-style line endings to DOS-style (CRLF) line endings. These are all extensions that aren't in our list of ones to check for whitespace (so jcheck won't catch them), but they should be converted back to Unix-style line endings to minimize diffs and avoid churn. Here is the list: Source/ThirdParty/icu/source/common/common.rc Source/ThirdParty/icu/source/common/common.vcxproj Source/ThirdParty/icu/source/common/common.vcxproj.filters Source/ThirdParty/icu/source/common/common_uwp.vcxproj Source/ThirdParty/icu/source/common/rbbicst.pl Source/ThirdParty/icu/source/common/rbbirpt.txt Source/ThirdParty/icu/source/common/sources.txt Source/ThirdParty/icu/source/i18n/i18n.rc Source/ThirdParty/icu/source/i18n/i18n.vcxproj Source/ThirdParty/icu/source/i18n/i18n.vcxproj.filters Source/ThirdParty/icu/source/i18n/i18n_uwp.vcxproj Source/ThirdParty/icu/source/i18n/regexcst.pl Source/ThirdParty/icu/source/i18n/regexcst.txt Source/ThirdParty/icu/source/i18n/sources.txt Source/ThirdParty/icu/source/stubdata/sources.txt Source/ThirdParty/icu/source/stubdata/stubdata.vcxproj Source/ThirdParty/icu/source/stubdata/stubdata.vcxproj.filters Source/ThirdParty/icu/source/tools/toolutil/sources.txt Source/ThirdParty/icu/source/tools/toolutil/toolutil.vcxproj ------------- PR: https://git.openjdk.org/jfx/pull/893
