On Thu, 4 Aug 2022 08:22:29 GMT, Paul <d...@openjdk.org> wrote: >> @gargoyle To clarify my inline comments, the minimal change you need to make >> is: >> >> 1. Change the tests of the four `jField` variables to remove the `> 0` (so >> it becomes a boolean test for non-null). >> 2. Change the tests of `width` and `height` to be `> 0` (rather than `> 1`) >> >> My other suggestions are optional. > > Thanks @kevinrushforth. Thinking about it, is there merit in changing the > `scalex` and `scaley` checks to be `!= 0`, as The main reason for checking at > all is to prevent a division by zero. Although unlikely, could fractional > values < 1 reach this code?
@gargoyle have you decided whether to change the scale tests to be `> 0`? Other than that pending question, the only required changes are the two I listed above. ------------- PR: https://git.openjdk.org/jfx/pull/743
