On Mon, 25 Jul 2022 11:40:33 GMT, Jose Pereda <jper...@openjdk.org> wrote:
>> Paul has updated the pull request with a new target base due to a merge or a >> rebase. The incremental webrev excludes the unrelated changes brought in by >> the merge/rebase. The pull request contains seven additional commits since >> the last revision: >> >> - Merge branch 'master' into JDK-8181084 >> - Merge branch 'master' into JDK-8181084 >> - Updated variable names to be a bit more consistent >> - Merge branch 'master' into JDK-8181084 >> - Merge branch 'master' into JDK-8181084 >> - Removing trailing whitespace. >> - Correctly scales hi-res icons in MacOS system menu items > > Looks good (and tested on Mac). I have some comments. Thanks for all the feedback. I've updated as per your suggestions @jperedadnr and @kevinrushforth. Let me know how this looks to you - I'm learning a lot here :-) I ran the tests as per your example and got `802 tests completes, 28 failed, 108 skipped`, which is exactly the same as when I run them on the `master` branch. Is there something I should be doing on a Mac to get zero failures? (Although, it's a lot better than my Linux box which gets 200 failed!) ------------- PR: https://git.openjdk.org/jfx/pull/743
