On Mon, 11 Jul 2022 21:37:43 GMT, Andy Goryachev <d...@openjdk.org> wrote:
> > One question: did you check that all of the methods you changed to private
> > scope are only called from other methods in the same class where they are
> > defined (and not called from another class, such as an inner class or
> > lambda, in the same file)?
>
> yes, of course.
Thanks for confirming (I spot-checked it, and didn't see any).
> besides, all these cases would generate an error or a warning in eclipse.
Are you sure? So you are saying that the following would generate a warning in
Eclipse?
public class SomeClass {
private double meth(double x) {
return Math.sqrt(x);
}
static class NestedClass {
double meth(SomeClass cls, double x) {
return cls.meth(x);
}
}
}
This is a simple (and contrived) example, but in more complicated cases, the
compiler sometimes has to generate a bridge method for private methods.
In any case, it sounds like this isn't even a potential problem here.
-------------
PR: https://git.openjdk.org/jfx/pull/824
