On Fri, 8 Jul 2022 22:00:24 GMT, Nir Lisker <nlis...@openjdk.org> wrote:

>> The fix includes:
>> - renaming of offending methods to avoid confusion
>> - explicitly declaring the offending methods as private
>
> modules/javafx.graphics/src/main/java/com/sun/prism/impl/ps/BaseShaderGraphics.java
>  line 92:
> 
>> 90:     BaseShaderContext getBaseShaderContext() {
>> 91:         return context;
>> 92:     }
> 
> Mentioning this was brought up in relation to a different PR: 
> https://github.com/openjdk/jfx/pull/628#issuecomment-924898354

I think it's a safe change (and this method should probably be made private, as 
it is only called from the same class).

-------------

PR: https://git.openjdk.org/jfx/pull/824

Reply via email to