On Wed, Nov 30, 2016 at 2:30 PM, Kristian Amlie <kristian.am...@mender.io> wrote: > On 28/11/16 12:18, Ed Bartosh wrote: >> I'd appreciate if you also do the following before sending v2: >> - check that your code doesn't regress pylint checks > > Is there an official process here? Sorry, it's not very well documented. > > Just running pylint3 manually on the scripts/lib/wic folder gives > identical results, however, running on rootfs.py alone, the rating > increases: > > Your code has been rated at 5.67/10 (previous run: 2.26/10, +3.41) > >> - add test case for your code to meta/lib/oeqa/selftest/wic.py >> - check that your code doesn't break oe-selftest --coverage -r wic and >> doesn't regress test coverage > > In the interest of saving me some build time, am I correct in assuming > that I need the "qemux86-64" MACHINE target for this to work? It appears > to be dependent on syslinux which has COMPATIBLE_HOSTS set to non-arm > only. Sorry, I'm a bit new to this framework.
You can either build for qemux86-64 or you can try patches from this series: http://lists.openembedded.org/pipermail/openembedded-core/2016-November/129187.html Basically, you should be interested in these: oe-selftest: enforce en_US.UTF-8 locale oeqa/utils/commands.py: allow use of binaries from native sysroot wic: selftest: avoid COMPATIBLE_HOST issues wic: selftest: do not assume bzImage kernel image This is how you add a test: http://lists.openembedded.org/pipermail/openembedded-core/2016-November/129192.html Running tests is as simple as: oe-selftest -r wic.Wic.test_your_test # runs single test oe-selftest -r wic.Wic # runs all wic tests Regards, -- Maciej Borzecki RnDity -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
