On 25/11/16 11:33, Patrick Ohly wrote:
> On Fri, 2016-11-25 at 11:15 +0100, Kristian Amlie wrote:
>> + if os.stat(real_rootfs_dir).st_dev ==
>> os.stat(cr_workdir).st_dev:
>> + # Optimization if both directories are on the same
>> file system:
>> + # copy using hardlinks.
>> + cp_args = "-al"
>> + else:
>> + cp_args = "-a"
>> + exec_cmd("cp %s %s %s" % (cp_args, real_rootfs_dir,
>> new_rootfs))
>
> Not a full review (I'll leave that to Ed), just one thing which caught
> my eye: when the rootfs contains xattrs, they get lost here.
>
> Use oe.path.copyhardlinktree() instead, it also does the hardlinking
> trick.
Thanks, that's a good tip! I'll include that in the next patchset.
--
Kristian
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
