Op 1 okt. 2014, om 17:34 heeft Martin Jansa <martin.ja...@gmail.com> het volgende geschreven:
> On Wed, Oct 01, 2014 at 09:12:16AM +0100, Richard Purdie wrote: >> On Wed, 2014-10-01 at 06:10 +0200, Martin Jansa wrote: >>> On Tue, Sep 30, 2014 at 08:55:53PM -0700, Khem Raj wrote: >>>> On Tue, Sep 30, 2014 at 6:32 PM, Denys Dmytriyenko <de...@denix.org> wrote: >>>>> On Tue, Sep 30, 2014 at 06:25:57PM -0700, Khem Raj wrote: >>>>>> On Tue, Sep 30, 2014 at 5:55 PM, Denys Dmytriyenko <de...@denix.org> >>>>>> wrote: >>>>>>> This line above ^^^^ has a very long trail of whitespaces and it got >>>>>>> commited >>>>>>> that way, unfortunately :( >>>>>> >>>>>> Better was if you commented before it went in. >>>>> >>>>> And how would you suggest I was supposed to see it?? Nobody saw it. My >>>>> email >>>>> client is no different than others - it doesn't mark trailing >>>>> whitespaces. The >>>>> reason I saw it is because I ran "git log -p" on the file and that >>>>> explicitly >>>>> highlights trailing whitespaces in BRIGHT RED... :) >>>> >>>> just for that may be we should start using gerrit ;) >>> >>> I'm all for it, it would make my e-mail - review - patchwork - >>> master-next workflow a lot easier and reliable. >> >> And I am not. Why? I've actually tried using the thing and I absolutely >> *despise* its interface. This isn't just a mild dislike, I simply cannot >> do the things I want/need to do with it. >> >> I believe I should have some kind of a say in this since it will >> directly affect my workflow and general life (since I spend a lot of my >> time dealing with this). > >> Its appears to be very easy for other people to tell me how I should work >> though :(. > > Please calm down, we just said that we like it, we're not forcing it on > anyone and I don't think khem would start installing it on OE servers > without much longer and broader discussion between all people who should > have some kind of say in this.. > > FWIW: I despised the UI at first as well, then I got used to it (after a month > or so), now I really like it especially with the "New screen" UI > introduced IIRC in 2.8 version. That 'new screen' is indeed an improvement and I also found the switch to make it show a unidiff instead of side-by-side. I still despise the UI, though, but not as much as before :) regards, Koen > Only annoying part for me is more > complicated permissions model (which I luckily don't need to > change so often) and missing option to use "simple" server side hooks. > > Regards, > > -- > Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
