On Tue, Sep 30, 2014 at 08:55:53PM -0700, Khem Raj wrote: > On Tue, Sep 30, 2014 at 6:32 PM, Denys Dmytriyenko <de...@denix.org> wrote: > > On Tue, Sep 30, 2014 at 06:25:57PM -0700, Khem Raj wrote: > >> On Tue, Sep 30, 2014 at 5:55 PM, Denys Dmytriyenko <de...@denix.org> wrote: > >> > This line above ^^^^ has a very long trail of whitespaces and it got > >> > commited > >> > that way, unfortunately :( > >> > >> Better was if you commented before it went in. > > > > And how would you suggest I was supposed to see it?? Nobody saw it. My email > > client is no different than others - it doesn't mark trailing whitespaces. > > The > > reason I saw it is because I ran "git log -p" on the file and that > > explicitly > > highlights trailing whitespaces in BRIGHT RED... :) > > just for that may be we should start using gerrit ;)
I'm all for it, it would make my e-mail - review - patchwork - master-next workflow a lot easier and reliable. -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com
signature.asc
Description: Digital signature
-- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
