On Thu, 2013-10-10 at 15:15 -0300, Otavio Salvador wrote:
> When passing the wrong value for UBOOT_CONFIG it ought to raise an
> error otherwise it is quite difficult for user to notice it didn't
> behave as expected.
>
> Reported-by: Lauren Post <lauren.p...@freescale.com>
> Signed-off-by: Otavio Salvador <ota...@ossystems.com.br>
> ---
> meta/classes/uboot-config.bbclass | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/meta/classes/uboot-config.bbclass
> b/meta/classes/uboot-config.bbclass
> index ba01bff..ff226a1 100644
> --- a/meta/classes/uboot-config.bbclass
> +++ b/meta/classes/uboot-config.bbclass
> @@ -51,4 +51,9 @@ python () {
> if len(items) > 1 and items[1]:
> bb.debug(1, "Appending '%s' to IMAGE_FSTYPES." % items[1])
> d.appendVar('IMAGE_FSTYPES', ' ' + items[1])
> +
> + # Go out as we found a match!
> + break
> + else:
> + raise bb.parse.SkipPackage("UBOOT_CONFIG %s is not supported" %
> ubootconfig)
> }
Shouldn't this be an exception such as ValueError rather than
SkipPackage?
Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
