On Thu, Jul 04, 2013 at 04:56:45PM +0100, Tomas Frydrych wrote: > On 04/07/13 16:39, Laurentiu Palcu wrote: > > On 07/04/2013 05:58 PM, Burton, Ross wrote: > >> On 4 July 2013 11:58, Laurentiu Palcu <laurentiu.pa...@intel.com> wrote: > > Even though the change you're proposing is OK, involves changing the > > desktop file to add the @SBIN@ pattern and move the sed line to > > do_install(). Compared to having one single line added in the > > postinstall... I would choose the latter, unless you elaborate on what > > do you actually mean by "nasty". > > Post install scripts should be avoided whenever possible and used only > for things that cannot be done at build or install time. This clearly > can be done at install time, so it should. I agree. However, in this particular case I'm just being consistent with what was already there. I would have personally moved the entire postinstall to do_install, but the previous sed cannot be moved. So, since we're stuck with that sed there, this one is just a harmless addition. This is what I mean!
Laurentiu > > Tomas > > -- > http://sleepfive.com > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
