Hi, I was hesitating a bit for this patch: typically when building gdb-cross there is no space constraint on the host where gdb-cross runs (a desktop PC / laptop, etc), so we could keep the separated definition of PACKAGECONFIG, and enable xz and minidebuginfod for gdb-cross per default and avoid requiring a rebuild of gdb-cross depending on which DISTRO_FEATURES is enabled.
This is especially true because when debugging with gdb-cross, a lot of libraries can get loaded, and the error message indicating the lack of lzma support / minidebuginfo is easy to miss, and gdb even reports that symbols are loaded when using "info sharedlibrary", because minidebuginfo symbols are not the "main" symbols, making it even more confusing. On the other hand there are corner-cases where gdb-cross runs on some kind of embedded X86 SBC / mini-pc, and where there could be some size constraints. What do you think? Étienne On Mon, Feb 10, 2025 at 4:50 PM Etienne Cordonnier via lists.openembedded.org <ecordonnier=snap....@lists.openembedded.org> wrote: > From: Etienne Cordonnier <ecordonn...@snap.com> > > Duplicating the PACKAGECONFIG variable in gdb-cross and gdb-common makes > it easy to forget updating one definition without updating the other. > However at the moment there is no need for two different definitions. > > xz is also useful for gdb-cross when minidebuginfo is enabled, so it also > needs > to be in the definition of PACKAGECONFIG in gdb-cross.inc > > Let's remove the definition from gdb-cross.inc to make maintenance easier. > This enables xz for gdb-cross as side-effect. > > Signed-off-by: Etienne Cordonnier <ecordonn...@snap.com> > --- > meta/recipes-devtools/gdb/gdb-cross.inc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/meta/recipes-devtools/gdb/gdb-cross.inc > b/meta/recipes-devtools/gdb/gdb-cross.inc > index 399f4bba97a..4f16deabe3e 100644 > --- a/meta/recipes-devtools/gdb/gdb-cross.inc > +++ b/meta/recipes-devtools/gdb/gdb-cross.inc > @@ -5,7 +5,6 @@ DEPENDS = "expat-native gmp-native mpfr-native > ncurses-native flex-native bison- > inherit python3native pkgconfig > > # Overrides PACKAGECONFIG variables in gdb-common.inc > -PACKAGECONFIG ??= "python readline ${@bb.utils.filter('DISTRO_FEATURES', > 'debuginfod', d)}" > PACKAGECONFIG[python] = > "--with-python=${PYTHON},--without-python,python3-native" > PACKAGECONFIG[readline] = > "--with-system-readline,--without-system-readline,readline-native" > PACKAGECONFIG[debuginfod] = "--with-debuginfod, --without-debuginfod, > elfutils-native" > -- > 2.43.0 > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#211100): https://lists.openembedded.org/g/openembedded-core/message/211100 Mute This Topic: https://lists.openembedded.org/mt/111104210/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-