> -----Original Message-----
> From: openembedded-core@lists.openembedded.org 
> <openembedded-core@lists.openembedded.org> On Behalf Of Alexander Kanavin
> Sent: den 29 februari 2024 10:01
> To: Changqing Li <changqing...@windriver.com>
> Cc: Changqing Li <changqing...@eng.windriver.com>; 
> openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH V5] systemd: fix a dead link under /var/log
> 
> On Thu, 29 Feb 2024 at 06:56, Changqing Li <changqing...@windriver.com> wrote:
> > The solution is also good. But package "${docdir}/systemd/README.logs"
> > in package systemd may make things more complicated.
> >
> > since in bitabke .conf, ${PN}-doc is before ${PN} in PACKAGES, and
> > FILES:${PN}-doc = "${docdir}  ...". we need to adjust the sequence,
> >
> > and may have influences to current list of files and directories that
> > are placed in a package.
> >
> > So maybe this patch is more simple and reasonable, and will not have
> > other impact.
> 
> That's right. It's possible but not obvious how to override that (I
> don't remember that from memory).
> 
> > That's ok, but can you make fixing the path to an absolute one a
> > separate, second commit then?
> >
> > if  use solution in this patch,  it is better they are in one commit.  I
> > can update description more detail.
> 
> Please no. These are two separate issues, let's deal with them as
> separate changes.
> 
> Alex

Given how much churn this patch has generated for a file that probably 
no one will read, how about just not creating it in the first place? 
That is what we do with the following patch:

From 49483effbcb920d097487c58214518f2f3a9d479 Mon Sep 17 00:00:00 2001
From: Yang Lyu <ya...@axis.com>
Date: Mon, 20 Jun 2022 09:07:19 +0200
Subject: [PATCH] Do not create README in log directory

---
 tmpfiles.d/legacy.conf.in | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tmpfiles.d/legacy.conf.in b/tmpfiles.d/legacy.conf.in
index 4f2c0d7c43..62e2ae0986 100644
--- a/tmpfiles.d/legacy.conf.in
+++ b/tmpfiles.d/legacy.conf.in
@@ -12,9 +12,6 @@

 d /run/lock 0755 root root -
 L /var/lock - - - - ../run/lock
-{% if CREATE_LOG_DIRS %}
-L /var/log/README - - - - ../..{{DOC_DIR}}/README.logs
-{% endif %}

 # /run/lock/subsys is used for serializing SysV service execution, and
 # hence without use on SysV-less systems.

//Peter

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#196429): 
https://lists.openembedded.org/g/openembedded-core/message/196429
Mute This Topic: https://lists.openembedded.org/mt/104598170/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to